Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new types module #429

Merged
merged 1 commit into from
Dec 7, 2023
Merged

feat: add new types module #429

merged 1 commit into from
Dec 7, 2023
+228 −289

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Dec 6, 2023 •
edited
Loading

This PR moves "floating" types from the lib.rs to a new, types.rs file.

My objective is to have a lib.rs file that simply has imports and uses.

This PR also brings back the TxOut and LocalUtxo types.

@thunderbiscuit thunderbiscuit force-pushed the typesmodule branch 3 times, most recently from 97dec1d to b8309fc Compare December 6, 2023 18:33
@thunderbiscuit thunderbiscuit requested a review from reez December 6, 2023 18:33
@thunderbiscuit thunderbiscuit self-assigned this Dec 6, 2023
@thunderbiscuit thunderbiscuit added this to the alpha.3 milestone Dec 6, 2023
reez
reez approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea that is in sync with how bdk handles this.

ACK 6b177f0

@thunderbiscuit thunderbiscuit merged commit 6b177f0 into bitcoindevkit:master Dec 7, 2023
17 checks passed
@thunderbiscuit thunderbiscuit deleted the typesmodule branch December 7, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reez reez reez approved these changes

Assignees

@thunderbiscuit thunderbiscuit

Labels
None yet
Projects
None yet
Milestone
alpha.3
Development

Successfully merging this pull request may close these issues.
2 participants
@thunderbiscuit @reez